feat(dedicated): add migration vcfaas banner #20062
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sefiani-ovh
force-pushed
the
feat/MANAGER-19946
branch
from
e40e672 to
267f530
Compare
github-actions
bot
added
universe-bare-metal-cloud
translation required
universe-hosted-private-cloud
feature
pauldkn
reviewed
Oct 29, 2025
...icated-cloud/customer-vcfaas-migration-banner/customer-vcfaas-migration-banner.controller.js
Outdated
Show resolved
Hide resolved
...icated-cloud/customer-vcfaas-migration-banner/customer-vcfaas-migration-banner.controller.js
Outdated
Show resolved
Hide resolved
...nents/dedicated-cloud/customer-vcfaas-migration-banner/customer-vcfaas-migration-banner.html
Outdated
Show resolved
Hide resolved
...nents/dedicated-cloud/customer-vcfaas-migration-banner/customer-vcfaas-migration-banner.html
Outdated
Show resolved
Hide resolved
...components/dedicated-cloud/customer-vcfaas-migration-banner/translations/Messages_fr_FR.json
Show resolved
Hide resolved
sefiani-ovh
force-pushed
the
feat/MANAGER-19946
branch
from
267f530 to
7c88a34
Compare
github-actions
bot
added
the
has conflicts
pauldkn
previously approved these changes
Oct 30, 2025
ref: #MANAGER-19946 Signed-off-by: ahmed sefiani <[email protected]>
sefiani-ovh
force-pushed
the
feat/MANAGER-19946
branch
from
7c88a34 to
5a0fdb7
Compare
github-actions
bot
removed
the
has conflicts
pauldkn
approved these changes
Oct 30, 2025
darsene
reviewed
Oct 30, 2025
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "dedicated_cloud_dashboard_customer_vcfaas_migration_banner": "Nouvelle offre Public VCF as-a-Service - Tarifs ultra compétitifs et migration gratuite - Découvrir <a href=\"{{ url }}\" target=\"_blank\"> l'offre </a> et Testez votre éligibilité", | |||
There was a problem hiding this comment.
Strange mix of tenses
Either Découvrir ... et tester ... or Découvrez ... et testez ...
Suggested change
| "dedicated_cloud_dashboard_customer_vcfaas_migration_banner": "Nouvelle offre Public VCF as-a-Service - Tarifs ultra compétitifs et migration gratuite - Découvrir <a href=\"{{ url }}\" target=\"_blank\"> l'offre </a> et Testez votre éligibilité", | |
| "dedicated_cloud_dashboard_customer_vcfaas_migration_banner": "Nouvelle offre Public VCF as-a-Service - Tarifs ultra compétitifs et migration gratuite - Découvrir <a href=\"{{ url }}\" target=\"_blank\">l'offre</a> et testez votre éligibilité", |
Comment on lines
+13
to
+17
| this.pending = false; | ||
| this.displayMigrationBanner = false; | ||
| } | ||
|
|
||
| $onInit() { |
There was a problem hiding this comment.
Suggested change
| this.pending = false; | |
| this.displayMigrationBanner = false; | |
| } | |
| $onInit() { | |
| } | |
| $onInit() { | |
| this.pending = false; | |
| this.displayMigrationBanner = false; |
Comment on lines
+1761
to
+1770
| return this.OvhHttp.post( | ||
| `/dedicatedCloud/{serviceName}/requestContactForVmwareCloudDirectorMigration`, | ||
| { | ||
| rootPath: 'apiv6', | ||
| urlParams: { | ||
| serviceName, | ||
| }, | ||
| }, | ||
| ); | ||
| } |
There was a problem hiding this comment.
OvhHttp is deprecated, use $http instead
Comment on lines
+177
to
+188
| customerVcfaasMigrationBannerAvailability: /* @ngInject */ ( | ||
| ovhFeatureFlipping, | ||
| ) => | ||
| ovhFeatureFlipping | ||
| .checkFeatureAvailability( | ||
| 'dedicated-cloud:customerVcfaasMigrationBanner', | ||
| ) | ||
| .then((featureAvailability) => | ||
| featureAvailability.isFeatureAvailable( | ||
| 'dedicated-cloud:customerVcfaasMigrationBanner', | ||
| ), | ||
| ), |
There was a problem hiding this comment.
There a lot of featureAvailability calls inside the resolve section. Making one call for each feature is not very performant.
It could be optimized to make only one call
features: /* @ngInject */ (ovhFeatureFlipping) => ovhFeatureFlipping
.checkFeatureAvailability('feature1', 'feature2',..., 'dedicated-cloud:customerSurveyBanner', 'dedicated-cloud:customerVcfaasMigrationBanner'),
customerVcfaasMigrationBannerAvailability: /* @ngInject */ (
features,
) => features.isFeatureAvailable(
'dedicated-cloud:customerVcfaasMigrationBanner',
),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #MANAGER-19946